Update pager workaround code to Fragment 1.3.6 #7149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
previously requested changes
Sep 27, 2021
app/src/main/java/androidx/fragment/app/FragmentStatePagerAdapterMenuWorkaround.java
Outdated
Show resolved
Hide resolved
TacoTheDank
force-pushed
the
updateFragWorkaround
branch
from
0f9b319 to
3fb4042
Compare
TacoTheDank
force-pushed
the
updateFragWorkaround
branch
from
3fb4042 to
7f2df25
Compare
litetex
reviewed
Oct 17, 2021
app/src/main/java/androidx/fragment/app/FragmentStatePagerAdapterMenuWorkaround.java
Outdated
Show resolved
Hide resolved
|
Made the PR to a draft until the above is fixed. |
TacoTheDank
force-pushed
the
updateFragWorkaround
branch
from
7f2df25 to
ed86b1c
Compare
|
Should be good now. |
litetex
approved these changes
Oct 20, 2021
|
@Stypox I believe your review has been addressed, so I'll dismiss it. |
This was referenced Nov 30, 2021
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
FragmentStatePagerAdapterto theFragmentStatePagerAdapterMenuWorkaround, since the current one is from a much older version.Of course, this class will eventually be removed for ViewPager2, but I figured I'd do this anyway until ViewPager2 can actually be implemented.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence